Conversation
* Adding the missing property LocalExtensionData in TestCase * Fixed the test.
…ft#1230) * Do not crash data collector if a extension initialize fails. * Add unit tests for the scenario.
* Fix for changes in XPathNavigator in netcoreapp2.0 * Removed IXPathNavigable.
* Loading native dll's correctly for UWP release mode * nit's * decouple process bitness with OS Architecture
smadala
requested review from
harshjain2,
mayankbansal018,
singhsarab and
sudiptadmsft
mayankbansal018
approved these changes
Oct 30, 2017
Contributor
mayankbansal018
left a comment
mayankbansal018
left a comment
There was a problem hiding this comment.
Verified for loading native dll fixe
HardCoded version of CLI to 2.1.0-preview1-007372 as the latest version has some issues. Reverted to old version of CLI because of dotnet/cli#7921
sudiptadmsft
left a comment
sudiptadmsft
left a comment
There was a problem hiding this comment.
scan for null in all xml function calls.
| childNodeNavigator = childElement.CreateNavigator(); | ||
| parentNavigator.AppendChild(childNodeNavigator); | ||
| var parentNode = xmlDocument.SelectSingleNode(nodeXPath.Substring(0, nodeXPath.LastIndexOf('/'))); | ||
| parentNode.AppendChild(childElement); |
…or (microsoft#1242) * GetOsArchitecture from Platform Abstraction to check for ARM * making sure path is always small
Merged
smadala
added a commit
that referenced
this pull request
Oct 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port fixes for following issues:
#1231 Add back
LocalExtensionDataAPI for adapters (fix regression reported by Debugger team)#1230 Do not crash data collector if extension fails to initialize or set environment variables (allow test runs with coverage in non Enterprise SKU)
#1226 Fix XPathNavigator for netcoreapp2.0 (enable
dotnet test --collectscenario)#1232 Use TPv2 as default for .NET 3.5 test projects
#1234 Loading native dll's correctly for UWP release mode.
#1238 HardCoded version of CLI to 2.1.0-preview1-007372.